Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression for custom configurations #3834

Merged
merged 1 commit into from Jun 4, 2023
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

fixes #3833

Did you add tests for your changes?

yes

If relevant, did you update the documentation?

No need

Summary

Fix regression

Does this PR introduce a breaking change?

No

Other information

No

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #3834 (ac7c27d) into master (14b9c18) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3834   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          22       22           
  Lines        1673     1673           
  Branches      484      484           
=======================================
  Hits         1529     1529           
  Misses        144      144           
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 92.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b9c18...ac7c27d. Read the comment docs.

@alexander-akait alexander-akait merged commit bb4f8eb into master Jun 4, 2023
56 checks passed
@alexander-akait alexander-akait deleted the issue-3833 branch June 4, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error after updating to v5.1.2
2 participants