Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: remove findup-sync from root package and move to utils #805

Closed
anshumanv opened this issue Mar 27, 2019 · 0 comments · Fixed by #806
Closed

Enhancement: remove findup-sync from root package and move to utils #805

anshumanv opened this issue Mar 27, 2019 · 0 comments · Fixed by #806

Comments

@anshumanv
Copy link
Member

Do you want to request a feature or report a bug?
refactor

What is the current behavior?
findup-sync is present in project root, it should be moved to utils package.
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
findup-sync is present in both project root and utils package.
If this is a feature request, what is motivation or use case for changing the behavior?
#801 (comment)

Sending a quick fix.

anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Mar 27, 2019
remove findup-sycn from package dir and move to utils

ISSUES CLOSED: webpack#805
anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Mar 30, 2019
single path util file

ISSUES CLOSED: webpack#805
@evenstensberg evenstensberg changed the title refactor(cli): remove findup-sync from root package and move to utils Enhancement: remove findup-sync from root package and move to utils Apr 8, 2019
anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Apr 19, 2019
remove findup-sycn from package dir and move to utils

ISSUES CLOSED: webpack#805
anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Apr 19, 2019
single path util file

ISSUES CLOSED: webpack#805
anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Apr 19, 2019
remove findup-sync from package dir and move to utils
cli(utils): added path-util to be used after next release
added path-util to be used after next release

ISSUES CLOSED: webpack#805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
@evenstensberg @anshumanv and others