From efae68bf25e41fb8a3e0775dc1bb60e901102e9d Mon Sep 17 00:00:00 2001 From: Anshuman Verma Date: Mon, 2 Nov 2020 18:12:56 +0530 Subject: [PATCH 1/2] fix: handle core flags for webpack 4 --- packages/webpack-cli/lib/webpack-cli.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/webpack-cli/lib/webpack-cli.js b/packages/webpack-cli/lib/webpack-cli.js index defd3904b9e..cacd5a2191b 100644 --- a/packages/webpack-cli/lib/webpack-cli.js +++ b/packages/webpack-cli/lib/webpack-cli.js @@ -31,6 +31,8 @@ class WebpackCLI { * @returns {void} */ _handleCoreFlags(parsedArgs) { + const coreCliHelper = require('webpack').cli; + if (!coreCliHelper) return; const coreConfig = Object.keys(parsedArgs) .filter((arg) => { return coreFlagMap.has(toKebabCase(arg)); @@ -39,8 +41,8 @@ class WebpackCLI { acc[toKebabCase(cur)] = parsedArgs[cur]; return acc; }, {}); - const coreCliHelper = require('webpack').cli; const coreCliArgs = coreCliHelper.getArguments(); + console.log(coreCliArgs, coreCliHelper); // Merge the core flag config with the compilerConfiguration coreCliHelper.processArguments(coreCliArgs, this.compilerConfiguration, coreConfig); // Assign some defaults to core flags From c353532a477d0f907a34895bb0cf36efc7a83130 Mon Sep 17 00:00:00 2001 From: Anshuman Verma Date: Mon, 2 Nov 2020 18:22:03 +0530 Subject: [PATCH 2/2] chore: rm log --- packages/webpack-cli/lib/webpack-cli.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/webpack-cli/lib/webpack-cli.js b/packages/webpack-cli/lib/webpack-cli.js index cacd5a2191b..7ea5eef84ce 100644 --- a/packages/webpack-cli/lib/webpack-cli.js +++ b/packages/webpack-cli/lib/webpack-cli.js @@ -42,7 +42,6 @@ class WebpackCLI { return acc; }, {}); const coreCliArgs = coreCliHelper.getArguments(); - console.log(coreCliArgs, coreCliHelper); // Merge the core flag config with the compilerConfiguration coreCliHelper.processArguments(coreCliArgs, this.compilerConfiguration, coreConfig); // Assign some defaults to core flags