fix(init): refactored the init.ts success message #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now the success message is more maintainable
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
Mar 28, 2019
dhruvdutt
reviewed
Mar 29, 2019
refactored init.ts to make code more readable
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
evenstensberg
approved these changes
Mar 30, 2019
|
@evenstensberg screenshot of changes ? |
|
Take a screenshot of the change |
dhruvdutt
approved these changes
Mar 31, 2019
|
@evenstensberg screenshot captured 👍
|
|
The visual change, not code |
|
No change as such. Before After Hence,this PR doesn't introduces and visual change. |
misterdev
pushed a commit
to misterdev/webpack-cli
that referenced
this pull request
Apr 23, 2019
Previously there was multiple `stdout.write` due to the presence of conditional statements. In this PR I have scrapped those repeating lines into a single `process.stdout.write` <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **What kind of change does this PR introduce?** Refactoring **Did you add tests for your changes?** No **If relevant, did you update the documentation?** Can't say **Does this PR introduce a breaking change?** Probably not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was multiple
stdout.writedue to the presence of conditional statements. In this PR I have scrapped those repeating lines into a singleprocess.stdout.writeWhat kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Can't say
Does this PR introduce a breaking change?
Probably not