Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: addon generator to async/await #849

Merged
merged 4 commits into from Apr 23, 2019

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
NA

Summary

  • Move async gen to async await.

Does this PR introduce a breaking change?

No

Other information
Not yet

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type is wrong

packages/generators/addon-generator.ts Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the returning type

packages/generators/addon-generator.ts Outdated Show resolved Hide resolved
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ematipico ematipico merged commit c1c33ae into webpack:master Apr 23, 2019
@anshumanv anshumanv deleted the chore/async-addongen branch April 23, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants