Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): minor fixes in the docs #874

Merged
merged 3 commits into from May 3, 2019

Conversation

pranshuchittora
Copy link
Member

Fixed indentation and corrected spellings

fixed indentation and corrected spellings
Copy link
Contributor

@misterdev misterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! :)

Do you think we need to change the indentation? I'd keep the old one

prettier makes the initial space twice for ul
@pranshuchittora
Copy link
Member Author

@misterdev have a look at the new changes.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the tabbing changes caused by your IDE or by the lint-staged where we run prettier?

@pranshuchittora
Copy link
Member Author

It's done using prettier (IDE).
Pls review this #851

@webpack-bot
Copy link

@pranshuchittora Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico ematipico merged commit 68b674b into webpack:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants