Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Hapi To The Other Servers Section Of README #1374

Closed
1 of 4 tasks
antonio-malcolm opened this issue Nov 1, 2022 · 3 comments
Closed
1 of 4 tasks

Adding Hapi To The Other Servers Section Of README #1374

antonio-malcolm opened this issue Nov 1, 2022 · 3 comments

Comments

@antonio-malcolm
Copy link

antonio-malcolm commented Nov 1, 2022

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

Hi all, it's good to meet everyone.

I noticed, on the webpack-dev-middleware README, a section for combining it with other servers. Currently, I have both the dev middleware and hot reloading middleware working with Hapi, in what I think is an interesting use case. It may be a bit complex, as-is, as an example, however, if there's interest, and no one's gotten to it yet, I think it could be simplified / adapted for the README

Your Proposal for Changes

Adding a Hapi server configuration to the README.

The relevant configuration, for both middleware and server, can be viewed, via the Github link below. There are two files - one which digests a Webpack configuration module, modifies that module's object, to manage and track whatever is available in the dev middleware's in-memory file system, and provide useful information describing such to the client.

I imagine it's not exactly obvious why one would do this, but the project itself is it, and the project is a monorepo, and this approach, while a bit more laborious up-front, pays off in the long term.

If you think the configuration linked below is useful, I'd be happy to assist in reducing it into something more readily digestible. The core, essentials of the configuration would be much the same, methinks.

https://github.com/antonio-malcolm/interreaction/tree/master/server

Cheers,
~Antonio

@alexander-akait
Copy link
Member

Hello, PR welcome

@antonio-malcolm
Copy link
Author

Great, thanks!

@alexander-akait
Copy link
Member

Let's close in favor #945, when we will ready to support it we will add docs, anyway if you want to help us - PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants