-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.0-rc.1 is incompatible with Fastify #602
Comments
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
(plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
We never will be compatibility with
it was just luck |
…570) (plugin-webpack-spa) Revert back webpack-dev-middleware to 3.7.2. Fixes build crash on access to app in development mode (webpack/webpack-dev-middleware#602) and removes extra logs to console (plugin-webpack-babel) Fix extra size of bundle in production mode, reduced ~44kb on the React example app (plugin-webpack-spa) Plugins clean-webpack-plugin and copy-webpack-plugin now is used only in production mode (plugin-webpack-spa) Remove script-ext-html-webpack-plugin
Supporting availability to use with two frameworks is bad idea, agreed |
In theory we can implement it, but we need improve tests, let's mark it is feature |
@artemirq (and any others who find this) - this is working fine with the lastest fastify and fastify-express as the middleware provider (instead of middie) |
@pearofducks yep, can you send a PR to docs how to use it with fastify? |
This is also breaking with |
we never supports faslity, please look at README, we write how you should use it with fastify |
4.0 breaks compatibility with vanilla node http too. ( |
PR exists #747, we never support is too, I think we fix it in near patch release |
Close in favor #945, hope we will improve this in near future |
Actual Behavior
When I trying to access application from browser, build is failing with error
TypeError: res.get is not a function
. In previous version, 3.7.2 it's not happenedI checked that error is happening in new version on this code line
Code
How Do We Reproduce?
npm init
npm i webpack webpack-dev-middleware@next fastify
src/index.js
and write something valid./run-webpack.js
node run-webpack.js
Notes
The text was updated successfully, but these errors were encountered: