Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with webpack@5 API #737

Merged
merged 2 commits into from Oct 21, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Support new webpack API for watching

It can be bug and feature together

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #737 into master will decrease coverage by 0.42%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   99.57%   99.15%   -0.43%     
==========================================
  Files          10       10              
  Lines         235      236       +1     
  Branches       71       72       +1     
==========================================
  Hits          234      234              
- Misses          1        2       +1     
Impacted Files Coverage Δ
src/index.js 96.87% <94.73%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7408fd...85bf7c2. Read the comment docs.

@alexander-akait
Copy link
Member Author

We need couple improvements in tests, avoid flaky tests and one improvement for memory usage for stats, I will do it tomorrow and we will do release ⭐

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@alexander-akait alexander-akait merged commit f6054a0 into master Oct 21, 2020
@alexander-akait alexander-akait deleted the fix-compatibility-with-webpack@5-api branch October 21, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants