Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer dependencies with webpack@5 #798

Merged
merged 1 commit into from Dec 15, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #797

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait changed the base branch from master to version-3 December 15, 2020 13:19
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #798 (89b27ea) into version-3 (68ae47b) will increase coverage by 2.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           version-3     #798      +/-   ##
=============================================
+ Coverage      97.08%   99.22%   +2.14%     
=============================================
  Files              7       10       +3     
  Lines            309      259      -50     
  Branches         101       83      -18     
=============================================
- Hits             300      257      -43     
+ Misses             9        2       -7     
Impacted Files Coverage Δ
lib/util.js
lib/fs.js
lib/reporter.js
lib/middleware.js
lib/context.js
lib/DevMiddlewareError.js
index.js
src/utils/handleRangeHeaders.js 100.00% <0.00%> (ø)
src/utils/ready.js 100.00% <0.00%> (ø)
src/utils/getFilenameFromUrl.js 97.36% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ae47b...89b27ea. Read the comment docs.

@alexander-akait alexander-akait merged commit 71b2bdf into version-3 Dec 15, 2020
@alexander-akait alexander-akait deleted the fix-peer-dependecies-with-webpack-5 branch December 15, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update peerDependencies to support webpack@^5.0.0 for webpack-dev-middleware@^3.7.2
1 participant