Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getFilenameFromUrl to API #911

Merged
merged 8 commits into from
May 19, 2021
Merged

feat: add getFilenameFromUrl to API #911

merged 8 commits into from
May 19, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 17, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

webpack/webpack-dev-server#3299 (comment)

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #911 (b58c7d8) into master (08f32fe) will decrease coverage by 0.68%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   98.59%   97.90%   -0.69%     
==========================================
  Files          10       10              
  Lines         284      287       +3     
  Branches      100      100              
==========================================
+ Hits          280      281       +1     
- Misses          4        6       +2     
Impacted Files Coverage Δ
src/utils/getFilenameFromUrl.js 97.50% <75.00%> (+0.13%) ⬆️
src/index.js 96.96% <100.00%> (+0.09%) ⬆️
src/middleware.js 96.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f32fe...b58c7d8. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this to docs

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will finish this PR, please always add tests and update docs in future, we can't merge new features/bugfixes without tests and docs

@alexander-akait alexander-akait merged commit 1edc726 into master May 19, 2021
@alexander-akait alexander-akait deleted the update-api branch May 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants