fix: add none and warning to clientLogLevel (#1901)

webpack · May 17, 2019 · 0ae9be8 · 0ae9be8
1 parent 45d39ac
commit 0ae9be8
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 4 deletions.
diff --git a/client-src/default/index.js b/client-src/default/index.js
@@ -61,6 +61,12 @@ const DEBUG = 'debug';
 const TRACE = 'trace';
 const SILENT = 'silent';
 
+// deprecated
+// TODO: remove these at major released
+// https://github.com/webpack/webpack-dev-server/pull/1825
+const WARNING = 'warning';
+const NONE = 'none';
+
 // Set the default log level
 log.setDefaultLevel(INFO);
 
@@ -121,6 +127,13 @@ const onSocketMsg = {
       case ERROR:
         log.setLevel(level);
         break;
+      // deprecated
+      case WARNING:
+        // loglevel's warning name is different from webpack's
+        log.setLevel('warn');
+        break;
+      // deprecated
+      case NONE:
       case SILENT:
         log.disableAll();
         break;

diff --git a/lib/options.json b/lib/options.json
@@ -37,7 +37,16 @@
       ]
     },
     "clientLogLevel": {
-      "enum": ["info", "warn", "error", "debug", "trace", "silent"]
+      "enum": [
+        "info",
+        "warn",
+        "error",
+        "debug",
+        "trace",
+        "silent",
+        "none",
+        "warning"
+      ]
     },
     "compress": {
       "type": "boolean"

diff --git a/test/__snapshots__/Routes.test.js.snap b/test/__snapshots__/Routes.test.js.snap
diff --git a/test/options.test.js b/test/options.test.js
@@ -120,8 +120,19 @@ describe('options', () => {
         failure: [false],
       },
       clientLogLevel: {
-        success: ['silent', 'info', 'error', 'warn', 'trace', 'debug'],
-        failure: ['whoops!', 'none', 'warning'],
+        success: [
+          'silent',
+          'info',
+          'error',
+          'warn',
+          'trace',
+          'debug',
+          // deprecated
+          'none',
+          // deprecated
+          'warning',
+        ],
+        failure: ['whoops!'],
       },
       compress: {
         success: [true],