From 2c00428f8156fb67790d991efbf5cb62ef363b8c Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Fri, 8 Oct 2021 15:04:54 +0530 Subject: [PATCH] fix: ci --- .../client-reconnect.test.js.snap.webpack4 | 26 ------------------- .../client-reconnect.test.js.snap.webpack5 | 26 ------------------- test/e2e/client-reconnect.test.js | 7 +++-- 3 files changed, 5 insertions(+), 54 deletions(-) diff --git a/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack4 b/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack4 index 2600e44f2f..a4e3a9badb 100644 --- a/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack4 +++ b/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack4 @@ -34,32 +34,6 @@ exports[`client.reconnect option specified as number should try to reconnect 2 t exports[`client.reconnect option specified as number should try to reconnect 2 times: response status 1`] = `200`; -exports[`client.reconnect option specified as true should try to reconnect unlimited times: console messages 1`] = ` -Array [ - "[HMR] Waiting for update signal from WDS...", - "Hey.", - "[webpack-dev-server] Hot Module Replacement enabled.", - "[webpack-dev-server] Live Reloading enabled.", - "[webpack-dev-server] Disconnected!", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", -] -`; - exports[`client.reconnect option specified as true should try to reconnect unlimited times: page errors 1`] = `Array []`; exports[`client.reconnect option specified as true should try to reconnect unlimited times: response status 1`] = `200`; diff --git a/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack5 b/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack5 index 2600e44f2f..a4e3a9badb 100644 --- a/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack5 +++ b/test/e2e/__snapshots__/client-reconnect.test.js.snap.webpack5 @@ -34,32 +34,6 @@ exports[`client.reconnect option specified as number should try to reconnect 2 t exports[`client.reconnect option specified as number should try to reconnect 2 times: response status 1`] = `200`; -exports[`client.reconnect option specified as true should try to reconnect unlimited times: console messages 1`] = ` -Array [ - "[HMR] Waiting for update signal from WDS...", - "Hey.", - "[webpack-dev-server] Hot Module Replacement enabled.", - "[webpack-dev-server] Live Reloading enabled.", - "[webpack-dev-server] Disconnected!", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", - "WebSocket connection to 'ws://127.0.0.1:8163/ws' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED", - "[webpack-dev-server] JSHandle@object", - "[webpack-dev-server] Trying to reconnect...", -] -`; - exports[`client.reconnect option specified as true should try to reconnect unlimited times: page errors 1`] = `Array []`; exports[`client.reconnect option specified as true should try to reconnect unlimited times: response status 1`] = `200`; diff --git a/test/e2e/client-reconnect.test.js b/test/e2e/client-reconnect.test.js index 0896ba3a7a..1e9958f3bd 100644 --- a/test/e2e/client-reconnect.test.js +++ b/test/e2e/client-reconnect.test.js @@ -52,10 +52,13 @@ describe("client.reconnect option", () => { // eslint-disable-next-line no-restricted-properties await page.waitForTimeout(1000 * Math.pow(2, 5) + Math.random() * 100); - expect(consoleMessages.map((message) => message.text())).toMatchSnapshot( - "console messages" + const retryingMessages = consoleMessages.filter((message) => + message.text().includes("Trying to reconnect...") ); + // snapshot can be different on different CI jobs + expect(retryingMessages.length).toBeGreaterThanOrEqual(5); + expect(pageErrors).toMatchSnapshot("page errors"); }); });