feat: improve error handling within startCallback and endCallback (…

…#3969)
webpack · Oct 24, 2021 · b0928ac · b0928ac
1 parent 74deac7
commit b0928ac
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -2175,7 +2175,9 @@ class Server {
   }
 
   startCallback(callback) {
-    this.start().then(() => callback(null), callback);
+    this.start()
+      .then(() => callback(null), callback)
+      .catch(callback);
   }
 
   async stop() {
@@ -2235,7 +2237,9 @@ class Server {
   }
 
   stopCallback(callback) {
-    this.stop().then(() => callback(null), callback);
+    this.stop()
+      .then(() => callback(null), callback)
+      .catch(callback);
   }
 
   // TODO remove in the next major release

diff --git a/test/e2e/api.test.js b/test/e2e/api.test.js
@@ -80,6 +80,29 @@ describe("API", () => {
     });
   });
 
+  it(`should catch errors within startCallback`, async () => {
+    const compiler = webpack(config);
+    const server = new Server(
+      { port, static: "https://absolute-url.com/somewhere" },
+      compiler
+    );
+
+    await new Promise((resolve) => {
+      server.startCallback((err) => {
+        expect(err.message).toEqual(
+          "Using a URL as static.directory is not supported"
+        );
+        resolve();
+      });
+    });
+
+    await new Promise((resolve) => {
+      server.stopCallback(() => {
+        resolve();
+      });
+    });
+  });
+
   it(`should work when using configured manually`, async () => {
     const compiler = webpack({
       ...config,