Handle IPv6-addresses correctly in checkHost() #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper handling of IPv6-addresses to the checkHost()-method. Like IPv4-addresses, IPv6 addresses are always allowed.
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 4 4
Lines 465 465
Branches 140 139 -1
=======================================
Hits 336 336
Misses 129 129
Continue to review full report at Codecov.
|
|
@usefulthink fantastic PR, thank you for getting this one in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add or update the
examples/?no
Summary
Add proper handling of IPv6-addresses to the checkHost()-method. Like
IPv4-addresses, IPv6 addresses are always allowed.
Does this PR introduce a breaking change?
no
Other information
Addresses @trygveaa's comment: #1007 (comment)