Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer generating ssl cert when one is already specified #1036

Merged
merged 4 commits into from Aug 28, 2017
Merged

No longer generating ssl cert when one is already specified #1036

merged 4 commits into from Aug 28, 2017

Conversation

mrsharpoblunto
Copy link
Contributor

What kind of change does this PR introduce?
Small startup time optimization

Did you add or update the examples/?

Summary
Skip the generation of a self signed SSL cert if an existing cert is already specified in the https options. The self signed SSL cert never gets used if you specify a cert in the options anyway, so theres not much point generating it in this case

Does this PR introduce a breaking change?
No

Other information

@jsf-clabot
Copy link

jsf-clabot commented Aug 10, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 13, 2017

Codecov Report

Merging #1036 into master will decrease coverage by 0.3%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   72.25%   71.94%   -0.31%     
==========================================
  Files           4        4              
  Lines         465      467       +2     
  Branches      139      140       +1     
==========================================
  Hits          336      336              
- Misses        129      131       +2
Impacted Files Coverage Δ
lib/Server.js 79.33% <0%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4729f...11672f7. Read the comment docs.

@shellscape
Copy link
Contributor

@mrsharpoblunto thanks for the PR! please sign the CLA and we can move forward

@mrsharpoblunto
Copy link
Contributor Author

@shellscape Signed the CLA

@shellscape shellscape merged commit e6ccbaf into webpack:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants