Proposed fix for ./log module not found #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 4 4
Lines 465 465
Branches 139 139
=======================================
Hits 336 336
Misses 129 129Continue to review full report at Codecov.
|
shellscape
suggested changes
Aug 22, 2017
client/index.js
Outdated
| @@ -79,7 +79,7 @@ var onSocketMsg = { | |||
| }, | |||
| "log-level": function(level) { | |||
| var hotCtx = require.context("webpack/hot", false, /^\.\/log$/); | |||
| if(hotCtx.keys().length > 0) { | |||
| if(hotCtx.keys().length > 0 && hotCtx.keys()["./log"]) { | |||
There was a problem hiding this comment.
I'd like to see a small modification here please.
var contextKeys = hotCtx.keys();
if(contextKeys.length && contextKeys["./log"]) {
|
@johan-lejdung thanks for the PR! we have one small change request and then we'll be happy to merge. |
added 2 commits
August 23, 2017 08:07
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix of #1049
Did you add or update the
examples/?No
Summary
This is a proposed fix of the #1049
Instead of just assuming that the module ./log is loaded there is a check to see if it actually is.
Does this PR introduce a breaking change?
It should not!
Other information