Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #998 to properly assign a random port and access the port assigned #1054

Merged
merged 2 commits into from Aug 29, 2017

Conversation

shellscape
Copy link
Contributor

What kind of change does this PR introduce?
Feature and Fix

Did you add or update the examples/?
No need

Summary
#998 requested the use of random ports and the ability to access the assigned random port.

Does this PR introduce a breaking change?
It introduces a corrective change. This PR also corrects the port reported by the CLI when a random port is assigned.

Other information

To access the port assigned you may go off of this example, or the following sample code:

const Server = require("webpack-dev-server/lib/Server");
conast server = new Server(compiler, options);

server.listen(0, '127.0.0.1', () => {
  const port = server.listeningApp.address().port;
});

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #1054 into master will decrease coverage by 0.16%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
- Coverage   73.54%   73.37%   -0.17%     
==========================================
  Files           5        5              
  Lines         446      447       +1     
  Branches      140      141       +1     
==========================================
  Hits          328      328              
- Misses        118      119       +1
Impacted Files Coverage Δ
lib/util/createDomain.js 37.5% <25%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69239ce...89cdd00. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant