Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1064 by switching to a named logger #1070

Merged
merged 1 commit into from Sep 5, 2017
Merged

Fixes issue #1064 by switching to a named logger #1070

merged 1 commit into from Sep 5, 2017

Conversation

bdurrer
Copy link
Contributor

@bdurrer bdurrer commented Sep 5, 2017

What kind of change does this PR introduce?
bugfix

Did you add or update the examples/?
no

Summary
This solves issue #1064
So far, the client JS of webpack-dev-server used the root logger and also changed the configuration of the root logger. This results in webpack overwriting the application's logging configuration.
The PR switches to a named logger, as suggested in the issue description.

Does this PR introduce a breaking change?
I don't think it could break an app.

However, if an application uses loglevel and expects webpack-dev-server to configure the root logger, it might have an different log level than expected.
The solution for the app would be to call loglevel's setLevel or setDefaultLevel (which is how you should do it anyway).

@jsf-clabot
Copy link

jsf-clabot commented Sep 5, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #1070 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files           5        5           
  Lines         451      451           
  Branches      143      143           
=======================================
  Hits          330      330           
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00fcb3...0a5d47f. Read the comment docs.

@shellscape
Copy link
Contributor

@bdurrer looks good. please sign the CLA (see first comment) and we can move forward

@bdurrer
Copy link
Contributor Author

bdurrer commented Sep 5, 2017

@shellscape
I did sign the CLA, but I used the wrong email. Adding the other email to the GitHub account did not help, nor can I change the js-cla data anymore after submitting 😒

@bdurrer
Copy link
Contributor Author

bdurrer commented Sep 5, 2017

Resetting and commiting the same thing again worked.

@shellscape
Copy link
Contributor

ah perfect, thanks!

@shellscape shellscape merged commit f166177 into webpack:master Sep 5, 2017
@bdurrer bdurrer deleted the issue-1064 branch September 5, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants