Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.log() left in lib/Server.js #1106

Closed
1 of 2 tasks
harryfino opened this issue Sep 19, 2017 · 1 comment
Closed
1 of 2 tasks

console.log() left in lib/Server.js #1106

harryfino opened this issue Sep 19, 2017 · 1 comment

Comments

@harryfino
Copy link

  • Operating System: Mac OS 10.12.6
  • Node Version: 8.5.0
  • NPM Version: 5.4.1
  • webpack Version: 3.5.6
  • webpack-dev-server Version: 2.8.0
  • This is a feature request
  • This is a bug

Code

Errant log message in lib/Server.js added during pull-request #1060.
image

Expected Behavior

The console.log() line that outputs "connection.remotePort" to the command line would be configurable, listen to "noInfo" flag in webpack.config.js, or not be output at all.

Actual Behavior

Every connection causes a command line console output of "connection.remotePort" with the port number and there is no way to get rid of it.

For Bugs; How can we reproduce the behavior?

Call webpack-dev-server --open to start the server and make a connection in your browser. When your browser connects, the message will appear in the command line output.

@shellscape
Copy link
Contributor

@harryfino thanks for checking in. that was cleaned up and you'll find it removed in 2.8.2. I'd recommend adding a tool like david to your build process to alert you of newer versions of modules. It's also a good idea to search a repo for a keyword; searching for remotePort yields no results, meaning that it was already removed 😉 The "Blame" function on a file is also a great way to see when something was added, and in this case removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants