Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning for Setup Always Appears #1120

Closed
1 of 3 tasks
bdwain opened this issue Sep 27, 2017 · 1 comment
Closed
1 of 3 tasks

Deprecation Warning for Setup Always Appears #1120

bdwain opened this issue Sep 27, 2017 · 1 comment

Comments

@bdwain
Copy link
Contributor

bdwain commented Sep 27, 2017

  • Operating System: Mac Sierra
  • Node Version: 8.6
  • NPM Version: 5
  • webpack Version: 3.6.0
  • webpack-dev-server Version: 2.9.0
  • This is a bug
  • This is a feature request
  • This is a modification request

Code

  // webpack.config.js
any config will work

Expected Behavior

I should not see the deprecation warning when running webpack dev server via the command line if I don't have a setup hook in my config.

Actual Behavior

I see the message 'Using "setup" is deprecated and will be removed in the next major version. Please use the "before" and "after" hooks instead.'

For Bugs; How can we reproduce the behavior?

Just run webpack-dev-server with any config.

This seems to have been introduced in #1108. The code to log the warning is always run, even if you specified no setup hook.

I can open a PR to fix this if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants