Changed property descriptor for Array.includes polyfill #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 5 5
Lines 468 468
Branches 151 150 -1
=======================================
Hits 335 335
Misses 133 133
Continue to review full report at Codecov.
|
shellscape
reviewed
Oct 4, 2017
lib/polyfills.js
Outdated
| @@ -5,5 +5,11 @@ | |||
|
|
|||
| // internal-ip@2.x uses [].includes | |||
| if (!Array.prototype.includes) { | |||
| Array.prototype.includes = require('array-includes'); | |||
| const includes = require('array-includes'); | |||
| Object.defineProperty(Array.prototype, 'includes', { | |||
There was a problem hiding this comment.
would probably be better to use includes.shim(); here, no? https://github.com/ljharb/array-includes/blob/master/shim.js
|
It seems like there is no need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Changed the way of adding Array.includes polyfill for node.js <6.
Did you add or update the
examples/?No need to.
Summary
This is a fix for #1133.
Does this PR introduce a breaking change?
No