Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client is written in ES6 without transpile step #1136

Closed
1 of 3 tasks
billyjanitsch opened this issue Oct 5, 2017 · 3 comments
Closed
1 of 3 tasks

Client is written in ES6 without transpile step #1136

billyjanitsch opened this issue Oct 5, 2017 · 3 comments

Comments

@billyjanitsch
Copy link
Member

  • Operating System: macOS
  • Node Version: 8.6.0
  • NPM Version: 5.4.2
  • webpack Version: 3.6.0
  • webpack-dev-server Version: 2.9.1
  • This is a bug
  • This is a feature request
  • This is a modification request

Expected Behavior

webpack-dev-server injects a JS client into the browser. #1058 converted this client to ES6, but did not add any sort of transpile step. Therefore, the dev server breaks in older browsers, making it useless for testing an app in these browsers.

Was this intentional? I would expect the client to continue to work in older browsers, even if the server is upgraded to ES6.

Actual Behavior

Any bundle crashes when loaded in an older browser because of the client inject, e.g. old FF fails with SyntaxError: let is a reserved identifier in the console on widgets.

For Bugs; How can we reproduce the behavior?

Run the server for any bundle and open it in an older browser, e.g. Firefox 38.

@shellscape
Copy link
Contributor

Please do make sure you're perusing all of the info on the README 😉 https://github.com/webpack/webpack-dev-server#caveats

There are also several issues which address this which have enjoyed discussion and have been closed (#1101, #1104, #1084). Please try the search function on issues before creating another in the future 🔎

@billyjanitsch
Copy link
Member Author

Sorry -- I had searched through issues with "Firefox" as a keyword, but the existing issues happen to run into this issue in IE and Uglify.

@shellscape
Copy link
Contributor

No worries. FWIW I plugged in "ES6" to pull those three up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants