Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired certificate #1171

Closed
MizardX opened this issue Nov 2, 2017 · 3 comments
Closed

Expired certificate #1171

MizardX opened this issue Nov 2, 2017 · 3 comments

Comments

@MizardX
Copy link

MizardX commented Nov 2, 2017

The certificate included in version 2.9.3 of the npm package expired 2017-10-31 21:57:23 GMT. If the package was installed less than 30 days ago, it will not be replaced automatically.

Package info: https://www.npmjs.com/package/webpack-dev-server
Direct link: https://registry.npmjs.org/webpack-dev-server/-/webpack-dev-server-2.9.3.tgz

Would it break anything if the certificate was excluded from the npm package?

@MizardX
Copy link
Author

MizardX commented Nov 2, 2017

Just deleting the certificate is enough to get it to work. But this is not obvious.

@joshwiens
Copy link
Member

joshwiens commented Nov 2, 2017

That SSL cert is generated when you enable the HTTPS option, really should be in a deployment package.

Update: It's not in 2.9.1 so i'm betting that is something that should be ignored & wasn't.

https://github.com/webpack/webpack-dev-server/blob/master/package.json#L37

//cc @shellscape ^^

@shellscape
Copy link
Contributor

@d3viant0ne yeah that was a mistake. I've got a patch release to do so I'll include that fix.

@MizardX please note that issue templates are not optional, and as stated in ours, if you remove it or ignore it the next time, your issue will be closed without examination. it is not cool to remove an issue template. always fill them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants