Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options schema inconsistency for logLevel #1372

Merged
merged 1 commit into from May 2, 2018
Merged

Fix options schema inconsistency for logLevel #1372

merged 1 commit into from May 2, 2018

Conversation

sergkop
Copy link
Contributor

@sergkop sergkop commented Apr 10, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

I tried to use webpack-dev-server with {logLevel: 'silent'} option, but it fails with the following error

WebpackDevServerOptionsValidationError: Invalid configuration object. webpack-dev-server has been initialised using a configuration object that does not match the API schema.
 - configuration.logLevel should be one of these:
   "trace" | "debug" | "info" | "warn" | "error" | "none"

That happens because the options schema defines an incorrect 'none' value, while webpack-log expects the 'silent' value.

Breaking Changes

Additional Info

The correct level name expected by webpack-log is 'silent' rather than 'none'
@jsf-clabot
Copy link

jsf-clabot commented Apr 10, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #1372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files           6        6           
  Lines         494      494           
  Branches      160      160           
=======================================
  Hits          391      391           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a90c7...4a83325. Read the comment docs.

@SpaceK33z SpaceK33z merged commit 2dafb77 into webpack:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants