Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendMsg('Progress', data) #1427

Merged
merged 2 commits into from Jul 22, 2018
Merged

sendMsg('Progress', data) #1427

merged 2 commits into from Jul 22, 2018

Conversation

nojvek
Copy link
Contributor

@nojvek nojvek commented Jun 21, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

Motivation / Use-Case

One line change.

Context: we maintain a module that shows a webpack status bar on the browser page. It handles ok, error, status e.t.c messages but since progress isn't sent out we can't respond to that.

https://github.com/mixpanel/webpack-dev-server-status-bar

The goal is to make the bar respond to progress by showing a fixed bar on top that increases in width as progress increases. For this to happen webpack-dev-server needs to send the event via postMessage

Breaking Changes

No breaking changes.

@nojvek
Copy link
Contributor Author

nojvek commented Jun 21, 2018

Travis CI failed because it couldn't install modules. Any chance someone can re-run that please?

@nojvek
Copy link
Contributor Author

nojvek commented Jun 26, 2018

@SpaceK33z @shellscape. Kind ping.

@shellscape
Copy link
Contributor

Sorry, but I no longer maintain this repo and recommend people use webpack-serve.

@nojvek
Copy link
Contributor Author

nojvek commented Jun 27, 2018

Do you know who the maintainer is @shellscape ? I saw your name with @SpaceK33z on the README.

webpack-dev-server has 1.6 million weekly downloads. I'm guessing a ton of people and production code already depends on this package. It is a great piece of software that I use every single day and I'm very sad to see it added to npm's growing pile of abandoned modules 😢

@shellscape
Copy link
Contributor

As far as I know @SpaceK33z is the only one still poking at this module. It's recommended that you try webpack-serve, as it's under active development. This package is still around for users that need support for browsers that are old or are way behind spec. Lots of users in China are in that group because the primary browsers there are very behind spec.

@nojvek
Copy link
Contributor Author

nojvek commented Jul 21, 2018

Kind ping @SpaceK33z, any chance you'll be able to take a look at this and publish a patch version please?

Thanks.

@codecov
Copy link

codecov bot commented Jul 22, 2018

Codecov Report

Merging #1427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files           6        6           
  Lines         497      497           
  Branches      161      161           
=======================================
  Hits          394      394           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aad42d...d653089. Read the comment docs.

@SpaceK33z SpaceK33z merged commit bb4b469 into webpack:master Jul 22, 2018
@SpaceK33z
Copy link
Member

Thanks! Will do a release soon.

@nojvek
Copy link
Contributor Author

nojvek commented Jul 22, 2018

You da best! Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants