Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin): handle process signals correctly when the server isn't ready yet #1432

Merged
merged 1 commit into from Aug 26, 2018
Merged

fix(bin): handle process signals correctly when the server isn't ready yet #1432

merged 1 commit into from Aug 26, 2018

Conversation

edi9999
Copy link
Contributor

@edi9999 edi9999 commented Jun 26, 2018 •
edited by michael-ciniawsky

@michael-ciniawsky michael-ciniawsky changed the title Fix SIGINT handling to work even if server not yet ready fix(bin): SIGINT handling to work even if the server is not yet ready Aug 21, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.1.6 milestone Aug 21, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(bin): SIGINT handling to work even if the server is not yet ready fix(bin): handle SIGINT even if the server is not ready yet Aug 22, 2018
@edi9999
Copy link
Contributor Author

edi9999 commented Aug 23, 2018

I have just pushed a fix that fixes the eslint issues. Hope this is going to be merged soon !

@codecov
Copy link

codecov bot commented Aug 23, 2018 •
edited

Codecov Report

Merging #1432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files           5        5           
  Lines         494      494           
  Branches      161      161           
=======================================
  Hits          390      390           
  Misses        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2220c4...b724899. Read the comment docs.

@michael-ciniawsky michael-ciniawsky modified the milestones: 3.1.6, 3.2.0 Aug 26, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(bin): handle SIGINT even if the server is not ready yet fix(bin): handle process signals correctly if the server is not ready yet Aug 26, 2018
michael-ciniawsky
michael-ciniawsky approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edi9999 Thx

@michael-ciniawsky michael-ciniawsky changed the title fix(bin): handle process signals correctly if the server is not ready yet fix(bin): handle process signals correctly when the server isn't ready yet Aug 26, 2018
@michael-ciniawsky michael-ciniawsky merged commit 334c3a5 into webpack:master Aug 26, 2018
@michael-ciniawsky
Copy link
Member

Released in v3.1.6 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 3.2.0 milestone Aug 26, 2018
This was referenced Aug 26, 2018
Open
Open
Closed
@michael-ciniawsky michael-ciniawsky mentioned this pull request Aug 29, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Assignees
No one assigned
Labels
semver: patch status: approved type: bug
Projects
No open projects
Dashboard
Fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edi9999 @michael-ciniawsky @alexander-akait