Update sockjs-client to 1.1.5 #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
=======================================
Coverage 79.27% 79.27%
=======================================
Files 6 6
Lines 497 497
Branches 161 161
=======================================
Hits 394 394
Misses 103 103Continue to review full report at Codecov.
|
|
My project has encountered the same situation. What should I do about it |
|
@SpaceK33z @evilebottnawi -- would it be possible to take a look at this PR? |
alexander-akait
approved these changes
Jul 21, 2018
|
/cc @SpaceK33z i think we should merge this and release patch |
|
Thanks! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A - the bug is not in webpack-dev-server but a dependency.
Motivation / Use-Case
If the response to
sockjs-clienttimes out, there is a bug in version 1.1.4 that will start an infinite reconnection. We are able to reproduce this timeout and infinite reconnect scenario in webpack-dev-server particularly when we have gzipping enabled and are bundling a really large JS file.You can read more about the issue here: sockjs/sockjs-client#334 (comment)
And upgrading to v1.1.5 will fix it as per this PR: sockjs/sockjs-client#358
Breaking Changes
N/A
Additional Info
N/A