Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use ca, pfx, key and cert as string #1542

Merged
merged 5 commits into from Jan 30, 2019
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 23, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fixes #1412

webpack-server supports this options as Buffer and string, we need port this feature.

Motivation / Use-Case

Better DX with https

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #1542 into master will increase coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1542     +/-   ##
=========================================
+ Coverage   74.34%   75.25%   +0.9%     
=========================================
  Files          10       10             
  Lines         690      687      -3     
=========================================
+ Hits          513      517      +4     
+ Misses        177      170      -7
Impacted Files Coverage Δ
bin/webpack-dev-server.js 58.28% <ø> (+1.45%) ⬆️
lib/Server.js 81.77% <100%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf1f76...204b179. Read the comment docs.

@alexander-akait alexander-akait merged commit 0b89fd9 into master Jan 30, 2019
@alexander-akait alexander-akait deleted the issue-1412 branch January 30, 2019 19:08
carlosgeos pushed a commit to carlosgeos/webpack-dev-server that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PFX ssl fails if path passed in from configuration file
2 participants