Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: What is the status of HTTP/2 support? #1713

Open
1 of 3 tasks
Aghassi opened this issue Mar 9, 2019 · 34 comments
Open
1 of 3 tasks

Question: What is the status of HTTP/2 support? #1713

Aghassi opened this issue Mar 9, 2019 · 34 comments

Comments

@Aghassi
Copy link

Aghassi commented Mar 9, 2019

  • Operating System: macOS 10.14.3
  • Node Version: 10
  • Yarn Version: 1.13.0
  • webpack Version: 4.29.4
  • webpack-dev-server Version: 3.2.1
  • This is a bug
  • This is a modification request
  • This is a question

I spent about an hour digging around yesterday and couldn't find the answer to this question, so I wanted to post here and get some insight.

I read through #516, which seems to indicate there is HTTP/2 supported, but I couldn't find any docs on how to enable it. All I found in the official docs was the line under this section https://webpack.js.org/configuration/dev-server/#devserverhttps saying that it can run with HTTP/2.

In the code in this repo I found this

if (!options.https.spdy) {
options.https.spdy = {
protocols: ['h2', 'http/1.1'],
};
}
// `spdy` is effectively unmaintained, and as a consequence of an
// implementation that extensively relies on Node’s non-public APIs, broken
// on Node 10 and above. In those cases, only https will be used for now.
// Once express supports Node's built-in HTTP/2 support, migrating over to
// that should be the best way to go.
// The relevant issues are:
// - https://github.com/nodejs/node/issues/21665
// - https://github.com/webpack/webpack-dev-server/issues/1449
// - https://github.com/expressjs/express/issues/3388
if (semver.gte(process.version, '10.0.0')) {
this.listeningApp = https.createServer(options.https, app);
} else {
/* eslint-disable global-require */
// The relevant issues are:
// https://github.com/spdy-http2/node-spdy/issues/350
// https://github.com/webpack/webpack-dev-server/issues/1592
this.listeningApp = require('spdy').createServer(options.https, app);
/* eslint-enable global-require */
}
} else {
this.listeningApp = http.createServer(app);
}

All of which links to issues and other repos which have either been closed or have no work being done on them. And according to this comment #1493 (comment), it is planned for v4, but nothing in the 4.0.0 milestone https://github.com/webpack/webpack-dev-server/milestone/4 seems to support that statement.

Ultimately, I'm confused as to the current situation. Does Webpack-Dev-Server support HTTP/2? If not, will it be supported in the future?

@alexander-akait
Copy link
Member

We support http2 using spdy module for backward compatibility with old node version, to enable http2 you should enable https option and spdy option, but i agree it is misleading, and looks we doesn't respect spdy (https://github.com/webpack/webpack-dev-server/blob/master/bin/options.js), thanks for issue. We need:

  1. Respect spdy (add alias http2) in CLI
  2. Add tests

For future version use http2 module instead node-spdy

@Aghassi
Copy link
Author

Aghassi commented Mar 11, 2019

As an added note, will respecting the spdy option in the CLI also reflect if I am using this programmatically by importing webpack-dev-server?

@alexander-akait
Copy link
Member

@Aghassi no, but fix it very easy

@JakobJingleheimer
Copy link

@evilebottnawi I'm a bit confused: the options file you linked contains no mention of spdy or http2 (or http/2). I've played around with this all evening, and I cannot get webpack-dev-server to serve over http2. Setting a CLI option does nothing, and the same is true for devServer.https.spdy: true (devServer.spdy causes a validation error).

I see it looks like it's coming in #1721, but it sounds like it was there before?

@alexander-akait
Copy link
Member

@jshado1 yep, now it is broken, this PR solve problem, next week release

@alexander-akait
Copy link
Member

Fixed #1713, http2 doesn't support on node >= 10 due express doesn't support this right now, we fix it after express was released

@alexander-akait
Copy link
Member

Mark as feature, we implement support after express do this

@hullevive
Copy link

Any updates on this?

@alexander-akait
Copy link
Member

@hullevive we use express under webpack-dev-server, so if you want http2 support please write this in express issue, we can't do something on our side

@ereztdev
Copy link

Still an issue in 2020? Trying to setup a localhost with https.
I'm getting : HTTP/2 is currently unsupported for Node 10.0.0 and above, but will be supported once Express supports it
Is there a release that has some sort of workaround? Even if it's dirty, I just need HTTPS for my vue app that uses webpack, thanks!

@alexander-akait
Copy link
Member

@ereztdev please write about it in express repo, they still not implement http2 support in 2020

@JakobJingleheimer
Copy link

expressjs/express#2761

@Herz3h
Copy link

Herz3h commented Jun 25, 2020

@evilebottnawi Is there a workaround in the meantime with node > 10.0 ? Using http/1.1 is so slow for development...

Edit: Here is example of a caddyfile to run a caddy reverse proxy for http/2:

localhost:3001

reverse_proxy 127.0.0.1:3000
tls localhost.pem localhost-key.pem

devServer should be run on port 3000 in this case. And caddy reverse proxy listens on port 3001. If you need to generate local certificates, I recommend mkcert

@7rulnik
Copy link

7rulnik commented Jun 25, 2020

@Herz3h you can launch nginx or caddy and setup proxy to webpack-dev-server

@wojtekmaj
Copy link
Contributor

spdy is effectively unmaintained

It just got an update this year after a long break, perhaps we should reconsider using it when developers explicitly want to? I'm using spdy for my personal project (it serves HTTP/2 well - unlike http2) and so far have no major issues with it on newest Node (14.x).

@isrmicha
Copy link

We should revive this

@dflock
Copy link

dflock commented Oct 23, 2020

The issues preventing spdy from working on node > 11.1 are now fixed, btw: spdy-http2/handle-thing#13

@isrmicha
Copy link

Node 15.0.1 have HTTP/3 QUIC experimental support.
webpack-dev-server will implement that ?

@csvan
Copy link

csvan commented Nov 1, 2020

How feasible would it be to use a different framework than Express to power webpack-dev-server? Express 5.0, which is tilted to have full http2 support, has been in alpha for about 7 years now, and there is no clear roadmap indicating when it will be released. Competing frameworks (koa, fastify etc) have all supported it for years and are actively maintained.

I asked the developers about the maintenance status and roadmap, and it seems to mostly boil down to them not having the resources and hoping the community will pitch in: expressjs/express#4451

@alexander-akait
Copy link
Member

alexander-akait commented Nov 2, 2020

we are looking at fastify for the our next default development framework

@JakobJingleheimer
Copy link

Express have thrown in the towel on http2: They've essentially said they're married to an underlying dead lib, spdy, for http2 support, so Express is unfortunately dying a slow death.

@wojtekmaj
Copy link
Contributor

Guys, this is awkward, but... I just checked and http2 flag.... Works? Looks like the specific check that prevented it from being enabled on Node 10+ is gone from lib/Server.js with this change:

b0161e9#diff-b706bbadb3d2315d99678f05e1f4bfd78a4bb4a7a6c65f3e81f1386fee3c883aL669-L678

So webpack-dev-server 4.0.0-beta.0 and up should run http/2 just fine. And it does!

image

@alexander-akait
Copy link
Member

Yep, should work

@alexander-akait
Copy link
Member

Stable release will be today

@csvan
Copy link

csvan commented Aug 19, 2021

Can confirm that https: true works great in 4.0. Awesome work @alexander-akait

@snitin315
Copy link
Member

Can we close this issue then?

@csvan
Copy link

csvan commented Aug 19, 2021

...however, http2 is quite unstable. Pretty sure that has to do with the SPDY package though.

@alexander-akait
Copy link
Member

Yep, if we need http2, we need fix compatibility with http2 module in express or migrate on fastify or other frameworks, it requires more work, firstly we should do compatibility inside webpack-dev-middleware, but there are more middleware which require compatibility too

@computnik
Copy link

computnik commented Apr 29, 2022

Seems like http2 is being supported now, but I observed that the proxy downgrades requests from http2 to http1.1, which was weird 🤔
Is that a known issue?

@alexander-akait
Copy link
Member

@computnik Can you clarify?

@lilbumblebear
Copy link

@computnik @alexander-akait I'm curious if anyone is seeing the following errors related to http2 and chrome:

net::ERR_HTTP2_PROTOCOL_ERROR 200

I'm getting these errors intermittently for both API requests using proxy and webpack chunks. I've gone through all of the normal checks for the error (server side settings) and everything looks ok. I did see that the requests are proxied through as HTTP1.1 not 2.

@xavierfoucrier
Copy link

Hello @alexander-akait 👋

HNY2024 to all developers 🎉

I am wondering about http2 support as well.
Use of http2 flag is deprecated. SPDY is deprecated.

Currently using the https flag with a self-signed certificate build with mkcert, but site is still running under http/1.1.
May be I am missing something? 🤔

Thanks! 🥭

@alexander-akait
Copy link
Member

@xavierfoucrier I am afraid express doesn't support it 😞 , but we want to allow to customize the app option and allow to use any web server in future, if you want to help it will be great

@xavierfoucrier
Copy link

Thanks @alexander-akait for you fast reply, as usual 🚀

I can understand the main direction, express team look a little bit slow on this 😓

Of course I would really love to be part of the webpack team and help on all webpack repositories: I am already using most of them. Unfortunately it means stop all my current private/professional projects to focus on open source, earn money through Github Sponsoring, and so on.. I am already part of open source teams, give part of my time for community, I guess I won't be lost inside this wide universe 🦄 Anyway, this is something I am (still) interested in!

My plans for 2024 are not write into the stone, so feel free to send me a direct message if it's something that could be possible.

Always a pleasure to talk with you Alexander 😽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests