fix: update clientLogLevel to match docs and error #1825
Conversation
|
|
|
Please fix ci problems, looks we need update snapshots |
Updated. Found a few other places the docs needed to be updated and changed as well. |
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 9 9
Lines 608 608
Branches 185 185
=======================================
Hits 544 544
Misses 54 54
Partials 10 10Continue to review full report at Codecov.
|
|
@gabemeola Could you update documentation? https://webpack.js.org/configuration/dev-server/#devserverclientloglevel |
|
@hiroppy For sure. Sent a pr webpack/webpack.js.org#2976 |
|
Thanks! |
As of [v3.4.0](https://github.com/webpack/webpack-dev-server/releases/tag/v3.4.0) the option "none" is no longer a valid value for webpack-dev-server's clientLogLevel config. webpack/webpack-dev-server#1825
|
This is going to be a breaking change for quite a few projects - might it be better to continue supporting "none" and "warning" as synonyms for "silent" and "warn"? |
|
hmm... according to the output, this pr is correct. but also I can understand what you are saying. /cc @evilebottnawi |
|
@hubgit yes you are right, can you open issue, it is breaking change and regression |
|
Created #1899 |
|
@hubgit thanks |
As of [v3.4.0](https://github.com/webpack/webpack-dev-server/releases/tag/v3.4.0) the option "none" is no longer a valid value for webpack-dev-server's clientLogLevel config. webpack/webpack-dev-server#1825
|
Hope this fix will be released soon as I'm also facing the same issue now |
|
This issue has already fixed and v3.4.1 has already released. |
* fix(docs): update clientLogLevel options From webpack/webpack-dev-server#1825 * Changed `none` to `silent` * Changed `warning` to `warn` * Added `trace` and `debug * docs(dev-server): add `none` and `warning` to clientLogLevel
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
The
clientLogLevelimplementation was incorrect with the documentation.https://webpack.js.org/configuration/dev-server/#devserverclientloglevel
This PR brings it up to date.
Currently if you use
trace,debug,warn, orsilentor will receive a cli incorrect param error.Breaking Changes
This will cause a cli error for users using
"clientLogLevel": "warning | none".The correct property should be
"warn"or"silent".