Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add none and warning to clientLogLevel #1901

Merged
merged 1 commit into from May 17, 2019
Merged

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented May 17, 2019

fixes: #1899
ref: #1825

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

hotfix and modify tests

Motivation / Use-Case

see #1899

Breaking Changes

no

Additional Info

@hiroppy
Copy link
Member Author

hiroppy commented May 17, 2019

I didn't modify the description of bin/options.js and lib/options.json because these values should be deprecated.

@hiroppy
Copy link
Member Author

hiroppy commented May 17, 2019

I created a ticket. https://github.com/webpack/webpack-dev-server/projects/1#card-21668614

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #1901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1901   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          14      14           
  Lines         817     817           
  Branches      259     259           
======================================
  Hits          719     719           
  Misses         84      84           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d39ac...638ac3e. Read the comment docs.

@alexander-akait
Copy link
Member

Need update shapshot, maybe we can rewrite this test from shapshot to other testing style

@hiroppy
Copy link
Member Author

hiroppy commented May 17, 2019

Yes, I forgot that I have rewritten client-src. 😇

@hiroppy
Copy link
Member Author

hiroppy commented May 17, 2019

updated

@alexander-akait
Copy link
Member

let's ignore npm audit (i don't know what the hell with npm again)

@hiroppy
Copy link
Member Author

hiroppy commented May 17, 2019

CI is green

@alexander-akait alexander-akait merged commit 0ae9be8 into master May 17, 2019
@alexander-akait alexander-akait deleted the feature/fix-1899 branch May 17, 2019 16:23
hiroppy added a commit that referenced this pull request Jun 10, 2019
hiroppy added a commit that referenced this pull request Jun 10, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
hiroppy added a commit that referenced this pull request Aug 1, 2019
hiroppy added a commit that referenced this pull request Aug 2, 2019
hiroppy added a commit that referenced this pull request Aug 5, 2019
hiroppy added a commit that referenced this pull request Sep 10, 2019
hiroppy added a commit that referenced this pull request Dec 12, 2019
hiroppy added a commit that referenced this pull request Dec 18, 2019
hiroppy added a commit that referenced this pull request Dec 19, 2019
hiroppy added a commit that referenced this pull request Dec 23, 2019
hiroppy added a commit that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] clientLogLevel should alias options "none" and "warning"
2 participants