Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add client code for electron-renderer target #1935

Merged
merged 1 commit into from May 29, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

#1912 (comment)

Breaking Changes

No

Additional Info

It is regression

@alexander-akait
Copy link
Member Author

/cc @ije you can try this PR, should works

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1935 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
+ Coverage    91.1%   91.11%   +0.01%     
==========================================
  Files          18       18              
  Lines         832      833       +1     
  Branches      260      261       +1     
==========================================
+ Hits          758      759       +1     
  Misses         70       70              
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/addEntries.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc83223...fda51cf. Read the comment docs.

@hiroppy hiroppy merged commit 9297988 into master May 29, 2019
@hiroppy hiroppy deleted the add-client-to-electron-renderer-target branch May 29, 2019 20:05
@hiroppy
Copy link
Member

hiroppy commented May 29, 2019

Oops, really sorry, I didn't read the comment. If you have problems, please do a revert.

@alexander-akait
Copy link
Member Author

I tested this and all work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants