fix(options): allow passing promise function of webpack.config.js #1947
Conversation
hiroppy
force-pushed
the
fix-#1946
branch
2 times, most recently
from
7bd8212
to
4c6dbee
Compare
test/helpers/test-bin.js
Outdated
|
|
||
| stdout += str; | ||
|
|
||
| // if webpack.config.js is a promise function, it won't be able to call `close` |
There was a problem hiding this comment.
I don't know why it wasn't able to call close, but I checked examples/general/config-promise and it works.
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
======================================
Coverage 91.5% 91.5%
======================================
Files 18 18
Lines 836 836
Branches 263 263
======================================
Hits 765 765
Misses 68 68
Partials 3 3Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hiroppy
force-pushed
the
fix-#1946
branch
2 times, most recently
from
1074179
to
479a130
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
======================================
Coverage 91.5% 91.5%
======================================
Files 18 18
Lines 836 836
Branches 263 263
======================================
Hits 765 765
Misses 68 68
Partials 3 3Continue to review full report at Codecov.
|
| }) | ||
| .catch((err) => { | ||
| // for windows | ||
| expect(err.stdout.includes('Compiled successfully.')).toEqual(true); |
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
======================================
Coverage 91.5% 91.5%
======================================
Files 18 18
Lines 836 836
Branches 263 263
======================================
Hits 765 765
Misses 68 68
Partials 3 3Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
yep
Motivation / Use-Case
fixes #1946, #1945
Breaking Changes
Additional Info