Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve description of magicHtml option #3772

Merged
merged 1 commit into from Sep 1, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

improve the description of magicHtml option

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #3772 (aad8c9b) into master (dfca34e) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3772      +/-   ##
==========================================
+ Coverage   92.88%   93.03%   +0.15%     
==========================================
  Files          14       14              
  Lines        1321     1321              
  Branches      463      463              
==========================================
+ Hits         1227     1229       +2     
+ Misses         87       85       -2     
  Partials        7        7              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfca34e...aad8c9b. Read the comment docs.

@alexander-akait alexander-akait merged commit b80610f into master Sep 1, 2021
@alexander-akait alexander-akait deleted the fix/improve-magic-html-description branch September 1, 2021 09:39
@alexander-akait
Copy link
Member

@snitin315 webpack can generate .mjs when you use outputModules: true, I think we should fix it too

@snitin315
Copy link
Member Author

@snitin315 webpack can generate .mjs when you use outputModules: true, I think we should fix it too

On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants