Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept connections with file: and chrome-extensions: protoco… #3822

Merged
merged 1 commit into from Sep 9, 2021

Conversation

alexander-akait
Copy link
Member

…l by default

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fixes #3821 fixes #3807

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #3822 (c677aaa) into master (beaeb27) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
- Coverage   92.80%   92.66%   -0.15%     
==========================================
  Files          14       14              
  Lines        1321     1323       +2     
  Branches      463      464       +1     
==========================================
  Hits         1226     1226              
- Misses         87       89       +2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 93.56% <100.00%> (+0.01%) ⬆️
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beaeb27...c677aaa. Read the comment docs.

@alexander-akait alexander-akait merged commit 138f064 into master Sep 9, 2021
@alexander-akait alexander-akait deleted the issue-3821 branch September 9, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

origin header of "file://" always rejected allowedHosts should support chrome-extension://
1 participant