Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close overlay on disconnection #3825

Merged
merged 3 commits into from Sep 9, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

close overlay when connection is disconnected

Breaking Changes

No

Additional Info

Also it fixed duplicate errors/warnings after stop and run again server

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #3825 (170e33b) into master (beaeb27) will decrease coverage by 0.13%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3825      +/-   ##
==========================================
- Coverage   92.80%   92.67%   -0.14%     
==========================================
  Files          14       14              
  Lines        1321     1337      +16     
  Branches      463      472       +9     
==========================================
+ Hits         1226     1239      +13     
- Misses         87       90       +3     
  Partials        8        8              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
client-src/index.js 81.18% <75.00%> (-0.64%) ⬇️
lib/Server.js 93.64% <100.00%> (+0.08%) ⬆️
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0002ebf...170e33b. Read the comment docs.

@alexander-akait alexander-akait merged commit 011bcf1 into master Sep 9, 2021
@alexander-akait alexander-akait deleted the fix-close-overlay-when-dev-server-closed branch September 9, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant