Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi compiler mode with multiple web targets #3840

Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 13, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

partial #3803

Motivation / Use-Case

Fix multi compiler mode logic for hot and live reload

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #3840 (2479fe1) into master (5df8b6a) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
+ Coverage   92.67%   92.79%   +0.12%     
==========================================
  Files          14       14              
  Lines        1337     1333       -4     
  Branches      472      471       -1     
==========================================
- Hits         1239     1237       -2     
+ Misses         90       88       -2     
  Partials        8        8              
Impacted Files Coverage Δ
client-src/utils/reloadApp.js 81.25% <100.00%> (ø)
lib/Server.js 93.61% <100.00%> (-0.03%) ⬇️
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df8b6a...2479fe1. Read the comment docs.

@alexander-akait alexander-akait merged commit e019bd2 into master Sep 13, 2021
@alexander-akait alexander-akait deleted the fix-multi-compiler-mode-with-multiple-web-targets branch September 13, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant