Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reloading logic for multi compiler mode #3841

Merged
merged 14 commits into from Sep 13, 2021
Merged

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP on tests

Motivation / Use-Case

fixes #3803

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #3841 (916a04b) into master (e019bd2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3841      +/-   ##
==========================================
+ Coverage   92.64%   92.70%   +0.05%     
==========================================
  Files          14       14              
  Lines        1333     1329       -4     
  Branches      471      466       -5     
==========================================
- Hits         1235     1232       -3     
+ Misses         90       89       -1     
  Partials        8        8              
Impacted Files Coverage Δ
client-src/index.js 81.37% <100.00%> (+0.18%) ⬆️
client-src/utils/reloadApp.js 81.48% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019bd2...916a04b. Read the comment docs.

@alexander-akait alexander-akait merged commit ef148ec into master Sep 13, 2021
@alexander-akait alexander-akait deleted the issue-3803 branch September 13, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser reloads infinitely when using multi-compiler mode
1 participant