Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display file name in overlay #3867

Merged
merged 3 commits into from Sep 24, 2021

Conversation

githoniel
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

since there is no test for overlayer yet, so I did not add test for it

Motivation / Use-Case

we are not display filename in webpack5 for error now

bug

compare to error ovelay in webpack-dev-server V3

fixed

Breaking Changes

no

Additional Info

add filename for error

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 22, 2021

CLA Signed

The committers are authorized under a signed CLA.

@alexander-akait
Copy link
Member

Please update tests

@githoniel
Copy link
Contributor Author

Please update tests

should I add test for it or just fix the lint?

@snitin315
Copy link
Member

Please update tests

should I add test for it or just fix the lint?

Both, CI should be all green.

client-src/overlay.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #3867 (a3d5b61) into master (22fa60b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3867   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          14       14           
  Lines        1334     1334           
  Branches      467      467           
=======================================
  Hits         1237     1237           
  Misses         89       89           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fa60b...a3d5b61. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait
Copy link
Member

@snitin315 Yep, I think we can merge it, I will send test cases today, maybe we need more fields here

@alexander-akait alexander-akait merged commit d20def5 into webpack:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants