Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid connection when web socket server is not running #3879

Merged
merged 4 commits into from Sep 25, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

fixes #3873

Breaking Changes

No

Additional Info

no

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #3879 (5bf73e0) into master (01b178d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   92.72%   92.63%   -0.09%     
==========================================
  Files          14       14              
  Lines        1334     1345      +11     
  Branches      467      468       +1     
==========================================
+ Hits         1237     1246       +9     
- Misses         89       92       +3     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
lib/Server.js 93.60% <100.00%> (-0.05%) ⬇️
client-src/index.js 80.76% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b178d...5bf73e0. Read the comment docs.

snitin315
snitin315 previously approved these changes Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not start connent to web socket server when server socket doesn't start
2 participants