feat: add client.reconnect option

[snitin315]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

WIP on tests.

Motivation / Use-Case

New option client.reconnect: boolean | number : allows to enable/disable/count of auto connect when client is disconnected

Breaking Changes

None

Additional Info

No

[alexander-akait]

We need handler in our client for this like for progress/etc, so developers can change value using web socket API

[alexander-akait]

Looks good, one note above, and let's add tests

[codecov]

Codecov Report

Merging #3912 (2c00428) into master (7298114) will decrease coverage by 0.35%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #3912      +/-   ##
==========================================
- Coverage   92.94%   92.58%   -0.36%     
==========================================
  Files          14       14              
  Lines        1346     1362      +16     
  Branches      467      474       +7     
==========================================
+ Hits         1251     1261      +10     
- Misses         88       93       +5     
- Partials        7        8       +1     

Impacted Files	Coverage Δ
bin/cli-flags.js	100.00% <ø> (ø)
client-src/index.js	78.18% <42.85%> (-2.59%)	⬇️
lib/Server.js	93.86% <100.00%> (+0.05%)	⬆️
lib/servers/WebsocketServer.js	91.42% <0.00%> (-5.72%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7298114...2c00428. Read the comment docs.

[alexander-akait]

Looks good, let's fix the tests

[alexander-akait]

Thanks

[alexander-akait]

@snitin315 I have another good task for you, we should implement the server option, like we have webSocketServer, it can be:

{
  server: "http" | "https" | "spdy" | { type: "http" | "https" | "spdy", options }
}

options will be passed to https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L1565, https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L1577, https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L1582

So it allows developer setup many options for server, regarding to http2 and https options, they will be removed in future in favor

webpack --server-type http
webpack --server-type https --server-options-key ./path/to/key
webpack --server-type http2 --server-options-key ./path/to/key

But now we will keep them to avoid breaking change, but the server options are more important, i.e.

// Pseudo code
const serverOptions = { 
  ...this.options.https,
  ...this.options.server.options
};

Ideally we should do this normalization in normalizeOptions and inside dev server we should use only this.options.server.type and this.options.server.options

[snitin315]

@alexander-akait sounds good, I will implement 👍