Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema for web socket server type #3913

Merged
merged 3 commits into from Oct 5, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

false is allowed only on for whole option, not for type

Breaking Changes

No, because it was broken before

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #3913 (26875e0) into master (af44710) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3913   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          14       14           
  Lines        1346     1346           
  Branches      467      467           
=======================================
  Hits         1249     1249           
  Misses         90       90           
  Partials        7        7           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af44710...26875e0. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Let's fix CI.

@alexander-akait alexander-akait merged commit f6aa6f7 into master Oct 5, 2021
@alexander-akait alexander-akait deleted the fix-schema-for-web-socket-server-type branch October 5, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants