Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make startCallback() and stopCallback() catch and handle errors like listen() and close() #3970

Closed
heath-freenome opened this issue Oct 23, 2021 · 1 comment

Comments

@heath-freenome
Copy link

heath-freenome commented Oct 23, 2021

Feature Proposal

After code inspecting startCallback and stopCallback currently they do not catch and handle errors like their listen and close counterparts do.

Feature Use Case

I have code that does the following:

const errorLogger = (err) => {
  if (err) {
    logger.error(err);
  }
};
...
clientDevServer.startCallback(errorLogger);

Which right now will never get called for an error like the way the code I replaced it with would have:

clientDevServer.listen(port, errorLogger);

Please paste the results of npx webpack-cli info here, and mention other relevant information

@alexander-akait
Copy link
Member

Fixed #3969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants