Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconnect tries #4044

Merged
merged 1 commit into from Nov 22, 2021
Merged

Fix reconnect tries #4044

merged 1 commit into from Nov 22, 2021

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Nov 19, 2021

Without this param passed, the client will only reconnect once.

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

Without this param passed, the client will only reconnect once.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 19, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #4044 (4506320) into master (285487f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4044   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          14       14           
  Lines        1441     1441           
  Branches      530      530           
=======================================
  Hits         1336     1336           
  Misses         97       97           
  Partials        8        8           
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️
lib/Server.js 94.09% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285487f...4506320. Read the comment docs.

@alexander-akait alexander-akait merged commit 9b32c96 into webpack:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants