Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload on warnings #4056

Merged
merged 1 commit into from Nov 25, 2021
Merged

fix: reload on warnings #4056

merged 1 commit into from Nov 25, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

fixes #4029

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #4056 (0b7feca) into master (5026601) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
- Coverage   92.74%   92.70%   -0.04%     
==========================================
  Files          14       14              
  Lines        1474     1480       +6     
  Branches      546      548       +2     
==========================================
+ Hits         1367     1372       +5     
- Misses         99      100       +1     
  Partials        8        8              
Impacted Files Coverage Δ
client-src/index.js 77.67% <75.00%> (-0.31%) ⬇️
lib/Server.js 94.10% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5026601...0b7feca. Read the comment docs.

@alexander-akait alexander-akait merged commit 1ba9720 into master Nov 25, 2021
@alexander-akait alexander-akait deleted the issue-4029 branch November 25, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR does not work if ESLint returned a warning or error
1 participant