Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show deprecation warning for both https and http2 #4069

Merged
merged 1 commit into from Dec 2, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

show deprecation warning for both https and http2 when used together.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #4069 (5f44b4a) into master (d096b0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4069   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files          14       14           
  Lines        1480     1481    +1     
  Branches      548      547    -1     
=======================================
+ Hits         1374     1375    +1     
  Misses         98       98           
  Partials        8        8           
Impacted Files Coverage Δ
lib/Server.js 94.11% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d096b0e...5f44b4a. Read the comment docs.

@snitin315 snitin315 merged commit d8d5d71 into master Dec 2, 2021
@snitin315 snitin315 deleted the fix/show-both-https-http2-deprecation-warnings branch December 2, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants