Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark --open-app deprecated in favor of --open-app-name #4091

Merged
merged 3 commits into from Dec 10, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

mark --open-app deprecated in favor of --open-app-name because they are duplicate flags.
Also, add TODO to remove --open-app.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #4091 (c90a4f7) into master (2e85dd1) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4091      +/-   ##
==========================================
- Coverage   92.77%   92.64%   -0.14%     
==========================================
  Files          14       14              
  Lines        1481     1481              
  Branches      547      547              
==========================================
- Hits         1374     1372       -2     
- Misses         99      101       +2     
  Partials        8        8              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/Server.js 94.02% <ø> (ø)
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e85dd1...c90a4f7. Read the comment docs.

@@ -114,7 +114,7 @@ Options:
--no-open Negative 'open' option.
--open-target <value...> Opens specified page in browser.
--open-app-name <value...> Open specified browser.
--open-app <value...> Open specified browser.
--open-app <value...> Open specified browser. Deprecated: please use open.app.name/--open-app-name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's for CLI use only CLI options, i.e. --open-app-name

@snitin315 snitin315 merged commit 693c28a into master Dec 10, 2021
@snitin315 snitin315 deleted the fix/open-app-deprecated branch December 10, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants