Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update descriptions of https and server options #4094

Merged
merged 4 commits into from Dec 10, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Dec 10, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

  • update descriptions of https options to be shorter.
  • Add deprecated info in server.options.cacert option.

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 changed the title fix: update descriptions of \https\ and server options fix: update descriptions of https and server options Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #4094 (5dddb2d) into master (97a8b18) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4094      +/-   ##
==========================================
- Coverage   92.77%   92.64%   -0.14%     
==========================================
  Files          14       14              
  Lines        1481     1481              
  Branches      547      547              
==========================================
- Hits         1374     1372       -2     
- Misses         99      101       +2     
  Partials        8        8              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a8b18...5dddb2d. Read the comment docs.

@snitin315 snitin315 merged commit f97c9e2 into master Dec 10, 2021
@snitin315 snitin315 deleted the fix/update-caert-description branch December 10, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants