fix: update --web-socket-server description
#4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4098 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 14 14
Lines 1481 1481
Branches 547 547
=======================================
Hits 1372 1372
Misses 101 101
Partials 8 8
Continue to review full report at Codecov.
|
anshumanv
reviewed
Dec 11, 2021
| @@ -1031,7 +1031,7 @@ | |||
| "$ref": "#/definitions/WebSocketServerType" | |||
| } | |||
| ], | |||
| "description": "Deprecated: please use 'webSocketServer.type'/'--web-socket-server-type' option." | |||
| "description": "Deprecated: please use '--web-socket-server-type' option." | |||
There was a problem hiding this comment.
not sure if displaying the flag makes sense when the user is using the feature from config
There was a problem hiding this comment.
Ideally, we should have a cliDescription property which webpack should respect if available. https://github.com/webpack/webpack/blob/c854e30df7f879d9989a7ab7aa83d1f0d1fa6862/lib/cli.js#L97
alexander-akait
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
update
--web-socket-serverdescription.Breaking Changes
None
Additional Info
No